search

grafeas / kritis

Deploy-time Policy Enforcer for Kubernetes applications
https://github.com/grafeas/kritis/blob/master/docs/binary-authorization.md
Apache License 2.0
694 stars 134 forks source link

Use go modules #591

Closed ghost closed 3 years ago

ghost commented 3 years ago

Dep has been deprecated as of September https://github.com/golang/go/issues/38158#issuecomment-689099575 2020. This PR removes dep and switches the project to use Go modules.

ooq commented 3 years ago

Thanks for cleaning this up! Can you fix the travis test, I think it's complaining because some vendor script is missing after the update: https://travis-ci.org/github/grafeas/kritis/builds/747482496

ooq commented 3 years ago

Looks like it's still failing :( @cjones-shopify

ghost commented 3 years ago

The Travis-CI pipeline takes quite a long time to run, I'm sorry it's taken so long for me to fix this PR! :<

ooq commented 3 years ago

No worries, @cjones-shopify! I've recently noticed that Travis might not pass back the build status back -- not sure why. I'll check when this rerun finishes.

ooq commented 3 years ago

Looks like it's being queued forever :(

ooq commented 3 years ago

Hi just a quick update that the travis issue seems common due to their migration phase from travis-ci.org to travis-ci.com. I just fixed it by completing the migration. The test looks good now (the Travis CI - Pull Request check) and you can ignore the continuous-integration/travis-ci/pr check. Sorry for the confusion!

ghost commented 3 years ago

Thank you so much @ooq!