grafeas / voucher

🎟 Voucher creates attestations for Binary Authorization
Apache License 2.0
73 stars 20 forks source link

Makefile should support v2 package changes #29

Closed sujaisd closed 3 years ago

sujaisd commented 3 years ago

Found the build script failed due to wrong directory path error.

CODE should point to the new v2/cmd package.

Followed the steps in the GCP Documentation [https://cloud.google.com/binary-authorization/docs/creating-attestations-voucher]

go build -o build/voucher_server -v ./cmd/voucher_server
stat /go/src/github.com/grafeas/voucher/cmd/voucher_server: directory not found
make: *** [Makefile:77: voucher_server] Error 1
google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

sujaisd commented 3 years ago

@googlebot I signed it!

catherinejones commented 3 years ago

Looks good to me, thank you @sujaisd! Once CI finishes please feel free to "Squash and Merge"!

sujaisd commented 3 years ago

Someone with write access should squash and merge it.

rxbchen commented 3 years ago