grafeas / voucher

🎟 Voucher creates attestations for Binary Authorization

Apache License 2.0

73 stars 20 forks source link

voucher-client: send User-Agent #52

Closed thepwagner closed 2 years ago

thepwagner commented 2 years ago

Modify the voucher client to send a customizable User-Agent header. This is easily spoofed, but helps a voucher-server to understand the distribution of its clients.

When voucher client is included as a library, the string voucher-client/2 is used. There's a method for clients to customize (e.g. my-awesome-builder/1.0). When voucher_client is used as a binary, the tagged version (e.g. voucher-client/2.6.2) is used.

Related

Ref https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent

lynnsh commented 2 years ago

Is this PR already merged in https://github.com/grafeas/voucher/pull/54?

thepwagner commented 2 years ago

Is this PR already merged in #54?

Yep, #54 targets this as a base branch so we'd have to merge this before it. That's because #54 is a refactor to client construction, so we wanted to include all the "current" usage.

I think we can consider this feature independently from #54 , as all it does is refactor the method of customization.