search

grafeas / voucher

🎟 Voucher creates attestations for Binary Authorization
Apache License 2.0
73 stars 24 forks source link

Client go containerregistry #71

Closed thepwagner closed 1 year ago

thepwagner commented 1 year ago

This is a slice of work to deprecate voucher's internal docker/ package, replacing it with the awesome https://github.com/google/go-containerregistry. This chunk is focussed on isolating the bits from docker/ we'll need to keep (AFAICT: the bit that extracts GCP projects from GCR urls?) and updating the ./cmd/voucher_client implementation to use go-containerregistry. As part of this, I also trimmed down the voucher_client implementation to DRY.

I want to use go-containerregistry because of #47 - I think voucher should become aware of multi-arch images/manifest lists, and I think switching to go-containerregistry's implementation is a better direction than adding to voucher's custom registry codez.

thepwagner commented 1 year ago

This was in service of https://github.com/grafeas/voucher/issues/47 , but I don't think we are going to do that.