search

grafov / m3u8

Parser and generator of M3U8-playlists for Apple HLS. Library for Go language. :cinema:
http://tools.ietf.org/html/draft-pantos-http-live-streaming
BSD 3-Clause "New" or "Revised" License
1.23k stars 315 forks source link

MediaSegment@SeqId should be the media sequence of an individual segment? #116

Closed leandromoreira closed 5 years ago

leandromoreira commented 6 years ago

Each sub manifest has its initial (media) sequence number and I was under the impression that the attribute SeqId from the MediaSegment was the individual media sequence for that segment, am I right?

Also, I was browsing through the docs and also the source code and I couldn't find where the attribute SeqId is filled.

leandromoreira commented 6 years ago

By the way, why did you pick SeqNo as uint64?

I think the type int64 might be enough, even if you pick an int32 type and a user sets each segment about 1s we would work for 70 years without wraparound.

leikao commented 5 years ago

By the way, why did you pick SeqNo as uint64?

Hi @leandromoreira , RFC 8216 defines the data type of SeqNo, the value range of decimal-integer is defined here.

o  decimal-integer: an unquoted string of characters from the set
   [0..9] expressing an integer in base-10 arithmetic in the range
   from 0 to 2^64-1 (18446744073709551615).  A decimal-integer may be
   from 1 to 20 characters long.
leandromoreira commented 5 years ago

Thanks @leikao do you know why SeqId is not being set?

leikao commented 5 years ago

Thanks @leikao do you know why SeqId is not being set?

Sorry @leandromoreira I don't know the reason why SeqId is not being set, may @grafov can give some points. You are welcome to submit a PR to improve this :)

leikao commented 5 years ago

@leandromoreira I made a PR #124 to support MediaSegment@SeqId, welcome to try it :)

leikao commented 5 years ago

PR #124 solved this issue, close it.