search

grafov / m3u8

Parser and generator of M3U8-playlists for Apple HLS. Library for Go language. :cinema:
http://tools.ietf.org/html/draft-pantos-http-live-streaming
BSD 3-Clause "New" or "Revised" License
1.23k stars 315 forks source link

Remove unnecessary args in goveralls #75

Closed yyoshiki41 closed 8 years ago

yyoshiki41 commented 8 years ago

I met this error in travis-ci.

$ $GOPATH/bin/goveralls -coverprofile=coverage.out -service=travis-ci -repotoken $COVERALLS_TOKEN
flag needs an argument: -repotoken
...
The command "$GOPATH/bin/goveralls -coverprofile=coverage.out -service=travis-ci -repotoken $COVERALLS_TOKEN" exited with 2.

Resolution

$COVERALLS_TOKEN is not necessary. c.f. Docs

For a public github repository, it is not necessary to define your repository key (COVERALLS_TOKEN).

In other ways, add = like this. maybe, it works.

This change is Reviewable

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 59.027% when pulling a1001b999510e0fb617e624c6a281925e6190dfa on yyoshiki41:fix/goveralls into 86c6f29e928613af618cc7e1a47b5172cf0532a1 on grafov:master.

bradleyfalzon commented 8 years ago

Thanks, and agreed, I don't have this token on my other services either.

grafov commented 8 years ago

@yyoshiki41 thank you for the explanation.

yyoshiki41 commented 8 years ago

👍