search

grafov / m3u8

Parser and generator of M3U8-playlists for Apple HLS. Library for Go language. :cinema:
http://tools.ietf.org/html/draft-pantos-http-live-streaming
BSD 3-Clause "New" or "Revised" License
1.23k stars 315 forks source link

Add reader support for EXT-OATCLS-SCTE35 and EXT-X-CUE-OUT #81

Closed bradleyfalzon closed 7 years ago

bradleyfalzon commented 7 years ago

Deprecation: MediaPlaylist.SetSCTE() has been deprecated, use MediaPlaylist.SetSCTE35() instead

SCTE has 3 new fields, .Syntax defines the format of the SCTE data, .CueType defines whether the cue point was start/mind/end, .Elapsed can be used for formats that track the elapsed time.

SCTE now supports another SCTE-35 syntax we've nicknamed OATCLS (due to the presence of this string in the tag), see sample-playlists/media-playlist-with-oatcls-scte35.m3u8 for an example. Both reads and writes are supported.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.8%) to 67.422% when pulling 7837bac5bebafd9789461d655791a1fef3250139 on bradleyfalzon:oatcls-scte35 into f5ad49ac5f5a8db4be6633dcddda01c5628f02c6 on grafov:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.8%) to 67.422% when pulling dafb983e5e47662b4720cd5d1e2ccec67f40f5e0 on bradleyfalzon:oatcls-scte35 into f5ad49ac5f5a8db4be6633dcddda01c5628f02c6 on grafov:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.8%) to 67.422% when pulling c29336f40a41c9f10d5074076a7ce489a0448c48 on bradleyfalzon:oatcls-scte35 into f5ad49ac5f5a8db4be6633dcddda01c5628f02c6 on grafov:master.

vishal24tuniki commented 7 years ago

Seems absolutely fine to me @bradleyfalzon :+1:

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.8%) to 67.422% when pulling 1f09c748a7eca76195125abda4e829c4fc2528bf on bradleyfalzon:oatcls-scte35 into f5ad49ac5f5a8db4be6633dcddda01c5628f02c6 on grafov:master.

bradleyfalzon commented 7 years ago

Thanks mate.

@grafov when you have a moment, can you review as well. I'll do some internal testing, but keen to get this merged sooner rather than later now there's no breaking changes.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.8%) to 67.422% when pulling 638e5da6fbd303b3b389c3363cfa4e76eeed38c1 on bradleyfalzon:oatcls-scte35 into f5ad49ac5f5a8db4be6633dcddda01c5628f02c6 on grafov:master.