search

grahac / alexa_request_verifier

Other
4 stars 3 forks source link

Fix upgrade path for 1.3.0 #2

Closed spunkedy closed 7 years ago

spunkedy commented 7 years ago

when trying to use in a 1.3 phoenix project I get this. 

  alexa_request_verifier (versions 0.1.3 and 0.1.4) requires ~> 1.2.3
grahac commented 7 years ago

Thanks Ed, for noticing this and updating with a pull request. Accepted and merged. I also added a new version and updated hex. One Q: I saw you added :inets as an external app. Any particular reason? Probably better to have it as a separate app but I was wondering if there was a restriction/change in Phoenix 1.3 that caused you to make the addition.

spunkedy commented 7 years ago

Yeah, the :httpc calls weren't working without it for some reason, chased it down to needing that.

Thanks for the merge!

grahac commented 7 years ago

Cool. Thx for letting me know!