Add docker support - Githubissues

JamoDevNich commented 4 years ago

The proposed changes would add docker support, and an additional section in the README with instructions

This resolves #1

JamoDevNich commented 4 years ago

Moving into draft state to do some further improvements

JamoDevNich commented 4 years ago

One caveat is that the container can't be run as any user other than root. This doesn't cause any issues with the default storage setup which uses docker volumes...

If the user changes this to a bind mount, this may cause problems since all the downloaded videos would be owned by root.

There are a few possible fixes for this:

Add a line in the Dockerfile to chmod the application directory, and allow the user to specify a user ID to run the container as (using --user)
Continue running the container as root, and use runuser to start node as a user ID specified by the user (using environment variables/ -e)

graham-walker / youtube-dl-react-viewer

Add docker support #2