Closed IvanAnishchuk closed 7 years ago
agreed, i'll make the changes and update (old habits die hard).
@graham I created a PR for this, see #2 for more information
Hi Carsten, I'm out of town until Sunday but I'll get this resolved as soon as I'm back
On Thu, Aug 3, 2017 at 11:06 Carsten Klein notifications@github.com wrote:
@graham https://github.com/graham I created a PR for this, see #2 https://github.com/graham/python_xid/pull/2 for more information
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/graham/python_xid/issues/1#issuecomment-320046507, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAFArowk0mnt2gPrRscfe_v5jNam80hks5sUgw7gaJpZM4Lm1VB .
It's a nice lib,small and pretty, and i still need python3 support.
Thanks to https://github.com/graham/python_xid/commit/a0778575e918ff8dfb2c63e2bdf4fe340da0b764 @silkentrance -> python 3 is now supported.
@xulei890817 python 2 and 3 are now supported
@graham Could this be released as a new version on PyPI as well? latest=1.0.4, which does not have this update
Thanks for the library!
@askogvold what is the problem with the fixes made by the PR? any issues with that?
@silkentrance no, nothing wrong with the fixes, it's great that it works on both now. - Just suggesting a release on PyPI.
@askogvold see #3 which targets your inquiry, sort of :grin:
😃
Isn't it, like, 2017 already? A few workarounds will be needed needed to support both py2 nd py3 but, actually, pure py3 code would've been simpler because bytes essentially is a byte array, no
map(ord, ...)
needed.