grahamearley / FirestoreGoogleAppsScript

A Google Apps Script library for accessing Google Cloud Firestore.
http://grahamearley.website/blog/2017/10/18/firestore-in-google-apps-script.html
MIT License
648 stars 109 forks source link

add batchwrite functionality #144

Open abkarino opened 2 years ago

abkarino commented 2 years ago

Resolves #65 , resolves #54 This allows batchwrites which has a solution for URL limit since the mask is put in the body. I did forget to remove one line in the package.json file that changed the repo param and will need to be reverted back before merging.

Checklist for your code

LaughDonor commented 2 years ago

I need to test these via clasp upload before I can accept. I plan to do this in the coming days.

ciriousjoker commented 2 years ago

Any updates?

trettimann commented 2 years ago

@LaughDonor Did you get around to testing it? :)

abkarino commented 2 years ago

The readme is updated, only writing tests remain.

leonardorb commented 1 year ago

hey folks, are we planning to promote this to the library soon?

ciriousjoker commented 1 year ago

@abkarino @grahamearley Will this be merged at some point?

abkarino commented 1 year ago

@abkarino @grahamearley Will this be merged at some point?

I am afraid, it is not really in my hand. At the moment, it only needs the tests to be written and the project maintainers to test it, verify it and merge it. I am already using it in my repo with some work projects.

charan-vendra commented 1 year ago

Hi @LaughDonor, Is this code going to be merged soon?

@abkarino great work, could you request a re-review?

MichaelJoo commented 1 year ago

I am really looking forward for this update to be merged - I have hundreds of sheets to import into Firestore, and each sheet is going to take at least 30 minutes or 1 hour to be fully imported. I reckon adding this feature would definitely reduce the time spent running the script.