Closed filmil closed 1 year ago
Sorry the PR was made in such a rush. Belatedly, here's a run-down of changes for posterity:
com_google_protobuf
to use zlib-1.2.13
. I haven't checked if it was possible to just fast-forward to a usable version, mostly because doing so likely implied other changes. I did follow them a bit, but got to a point where the entire app was updated, but didn't work. So I abandoned that approach for the time being. I still have a branch with that code and may give it another go. The most important update there would be updating to v9 of the go-app
framework.protoc
-> proto
, which introduced a harmless but unnecessary inconsistency between the project name on Github and the go package in use.bazel
version to 6.3.0 to improve reproducibility. It's annoying to have a dependency on the build system exact version, but the alternative of not knowing which bazel is compatible with the repo is even worse, so this would be an acceptable (to me) way to pin as much of the versioning as possible.app.wasm
and bootstrap.css
is now computed by bazel and passed on to the server. Flags were the most expedient way to achieve that.//protos
to //protos/api
. This makes the package not confuse go mod tidy
, so one can use regular go tools to update dependencies (and from there use gazelle to keep things up to date).bazel-bin
for the generated protos. This makes the bazel setup transparent to go
IDE tooling. These are arch specific unfortunately, so you may see things break once in a while. If they do, update the links.gofmt
on save.
Handles https://github.com/grahamjenson/bazel-golang-wasm-proto/issues/2
Things now compile out of the box. Happy to provide more details if needed.