search

grahamjenson / ger

Good Enough Recommendation (GER) Engine
376 stars 47 forks source link

Some new changes to recently_actioned_things_by_people breaks some tests in the RethinkdbESM #37

Closed grahamjenson closed 8 years ago

grahamjenson commented 9 years ago

The changes are: If an event has an expires_at date:

  1. Don't return expired events by default
  2. accept a expires_after date which filters events that do not expire after the given date.

This is to ensure that in a live system that no recommendation can be given from an expired event, or a specified time can be given that any recommendation based on a event must expire after. This is useful if because if you are generating recommendation for a website then a the user may need a few minutes to explore the recommendations so returning something that expires in say 5 seconds time would be useless OR if generating recommendations for an email campaign then returning recommendations that expire in the next few hours would be useless as well.

@thelinuxlich could you have a look at the recently_actioned_things_by_people method in the rethinkDB esm, I am sure you will find it basic to update but I could not see how :)

grahamjenson commented 8 years ago

The rethinkdb ESM has been moved into and external project https://github.com/grahamjenson/ger_rethinkdb_esm