search

grahammendick / navigation

Scene-Based Navigation for React and React Native
https://grahammendick.github.io/navigation/
Apache License 2.0
571 stars 40 forks source link

HidesTabBar not working on Android #741

Closed mHvNG closed 9 months ago

mHvNG commented 10 months ago

Just as the title says, the hidesTabBar property works for iOS, but not for Android. Is this by design or a bug?

grahammendick commented 10 months ago

The Navigation router is 100% native. It doesn't implement UI logic at all. It only wraps the underlying native apis. The hidesTabBar prop wraps the native hidesBottomBarWhenPushed on iOS. But there is no equivalent native api on Android.

mHvNG commented 10 months ago

Alright, I would suggest mentioning this is an iOS-only feature. As there's no mention of it now.

grahammendick commented 10 months ago

That's fair comment, thanks 👍

grahammendick commented 10 months ago

I've added a platform qualifier to each prop/component that is specific to either Android or iOS. Does this work for you?

grahammendick commented 10 months ago

@mHvNG will you get a chance to look through my changes ☝️ ?

grahammendick commented 9 months ago

@mHvNG If I don't hear back from you in the next couple of weeks I'll close this (and your other issues). If you're too busy, don't worry, we can always reopen them when you're free

grahammendick commented 9 months ago

@mHvNG Closing this down because you're unavailable. Can always reopen when you're free

mHvNG commented 9 months ago

Hi, I've been unavailable, because of sickness and my graduation. So I've been offline from GitHub and programming. The comments seem fine. This way we can use intellisense for this instead of trying if it works, so thanks!

grahammendick commented 9 months ago

Hey, congrats on your graduation. Thanks, I've reopened

grahammendick commented 9 months ago

@mHvNG I've had an idea for how hidesTabBar could work on Android. If you're interested let me know

grahammendick commented 7 months ago

I sketched out the idea. It's not quite the same as ios because can't have A -> B -> C with tab bar on A and C but not B. Once the tab bar is hidden on B it stays hidden for navigations from B