Closed salisuabubakar closed 8 months ago
Hi, I've updated the zoom sample to react native 0.73. There's nothing you need to edit, I've already updated the Navigation router podspec.
You're probably having a problem with a different one of your dependencies.
If you're using Fabric, in order to upgrade to react native 0.73 all of your dependencies need to be ready for react native 0.73. The Navigation router is ready but are your other dependencies?
Oh I see. You're editing the react-native-webview.podspec - I missed that bit. Yea, you can try that and it should work. It worked on the Navigation router, but I never tried it in react-native-webview. I just suggested it because that's the correct fix
OK this is what am doing in react-native-webview.podspec :
if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then s.compiler_flags = folly_compiler_flags + " -DRCT_NEW_ARCH_ENABLED=1" s.pod_target_xcconfig = {
# "OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
# "CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
install_modules_dependencies(spec)
}
Replace spec
with s
and get rid of the other stuff
if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then
install_modules_dependencies(s)
end
@salisuabubakar please let me know if it works
I'm gonna assume this worked because you haven't got back to me
It didnt work. Sorry for the late response.
Ok, you should raise this on the react-native-webview repo
Maybe you should give react-native-webview time to make a version that works with 0.73. I'm sure it's on their radar
Its unfortunate. Android is working perfectly but ios is the issue. Thanks
There's a react-native-webview PR that you can try
Yes its working. Thanks
Hi @grahammendick , i saw you poste this on react native webview :
if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then install_modules_dependencies(spec) end
Am having similar issue with react native 0.73 and the navigation router 9.11.0. I havre tried it and it didnt work. Not sure if am doing the right thing. I edited the react-native-webview.podspec file. Is it the right place ?
Thanks