grahampugh / erase-install

A script that automates downloading macOS installers, and optionally erasing or upgrading macOS in a single process. Watch the video!
https://grahamrpugh.com/2023/05/14/macaduk-presentation-eraseinstall.html
Apache License 2.0
834 stars 131 forks source link

[BUG] SwiftDialog displaying blank squares - SF Symbols in use not compatible with some versions of macOS #470

Closed BigMacAdmin closed 6 months ago

BigMacAdmin commented 9 months ago

Describe the bug The wiki states that eraseinstall.sh v.28+ should be compatible with macOS v.11 and up, however some SF symbols in use with SwiftDialog windows are not available in macOS 11 and 12

Using the SFSymbols.app provided by Apple, they tell us which version of macOS different symbols were introduced. When run on earlier versions of macOS, these icons appear as blank squares.

To Reproduce

Expected behavior SwiftDialog handles this problem on your behalf by showing a blank square, but I've seen folks on Slack ask about this.

Code/log output There is no relevant code snippet for htis

Screenshots image

Environment (please complete the following information):

Additional context Possible Solutions:

  1. Replace these icons with icons released in macOS 11
  2. Add logic to set these icons dependent upon the source OS
  3. Close this issue as "won't fix/don't care"

Let me know if you'd like a pull request for option 1 or 2

grahampugh commented 9 months ago

I'm going with these replacements, all of which should be compatible with macOS 11:

Screenshot 2023-12-08 at 15 12 33 Screenshot 2023-12-08 at 15 15 32 Screenshot 2023-12-08 at 15 14 18 Screenshot 2023-12-08 at 15 16 32

Look good?

grahampugh commented 9 months ago

https://github.com/grahampugh/erase-install/releases/tag/v32.0 to test