search

grahampugh / erase-install

A script that automates downloading macOS installers, and optionally erasing or upgrading macOS in a single process. Watch the video!
https://grahamrpugh.com/2023/05/14/macaduk-presentation-eraseinstall.html
Apache License 2.0
834 stars 131 forks source link

[FR] Leverage SwiftDialog's banner image and title #498

Open Bearzooka opened 5 months ago

Bearzooka commented 5 months ago

PLEASE NOTE THAT FEATURE REQUESTS ARE ONLY CONSIDERED AGAINST v.28.0+

Is your feature request related to a problem? Please describe. Not a problem, just a nice thing to have. I'm using SwiftDialog here and there and now include a nice banner we got from the design team. It would add to the consistency to use that banner as well while using erase-install to update Macs.

Describe the solution you'd like An additional couple of flags to point to a banner image and define the banner text (which would be used instead of the regular title)

Describe alternatives you've considered I've considered hardcoding this changes into the existing script, but that would mean I cannot longer use the package as it comes from the releases section.

Additional context Example of the banner I'm using on other dialogs image-1

grahampugh commented 4 months ago

@Bearzooka I don't want to get in the business of providing all sorts of variables for window size and shape, as there are already way too many parameters available but I don't want to move to a level of complexity that requires a json file or config profile such as is needed for things like Setup Your Mac or super.

I'm thinking the problem with offering an option to provide a banner image is that people will want ones of different sizes. I'm also not currently providing any options to customise titles and I don't want to do that either, (1) due to the localizations built in and (2) because as soon as I do that, people will want to be able to change every single dialog.

So the only manageable option I would think of is a fixed-sized banner, with the existing regular titles still used.

Bearzooka commented 4 months ago

@grahampugh Thanks for your reply.

I totally understand your position and in fact, AFAIK SwiftDialog has that kind of notion, where there's only the --bannerimage flag and it will default size. The only other change is that title becomes bannerText.