search

grahampugh / jamf-upload

Scripts for uploading packages to Jamf Cloud
Apache License 2.0
150 stars 39 forks source link

Add additional options support to base #112

Closed WardsParadox closed 3 months ago

WardsParadox commented 1 year ago

Add additional options field that can be specified to modify all curl requests in the event they are needed by certain environments (like an additional SSO login cookie)

Resolves #109

grahampugh commented 8 months ago

Hi, I'm afraid this conflicts with changes that were made since this PR to cope with API Clients. Some name other than curl_additional_opts is going to be needed, since we have additional_curl_opts already. Maybe custom_curl_opts?

WardsParadox commented 8 months ago

Should be a fairly easy lift. We've just been using the fork for this long to get it working. I'll see if I can get that done today so we can potentially merge back to main :)

WardsParadox commented 3 months ago

Hmm despite pulling from main and rebasing, seems like a conflict. Let me retry that