search

grahampugh / jamf-upload

Scripts for uploading packages to Jamf Cloud
Apache License 2.0
147 stars 37 forks source link

Update JamfPackageUploaderBase.py #134

Closed rickokid closed 5 months ago

rickokid commented 5 months ago

Tweak to strip any trailing slashes off JSS_URL. I know, it says it right here in the docs (https://github.com/grahampugh/jamf-upload/wiki/JamfUploader-AutoPkg-Processors) not to have it there, but it still took me a day to realise what was screwing up the processor!

I realise this will require the same update to all the JamfUploader processors - I'm happy to do pull requests for all of them if you're ok to use this tweak.

grahampugh commented 5 months ago

Good idea, I support this. If you were able to repeat the change in all the other processors that would be great 😊. Don't worry if not, I will get to it eventually.

rickokid commented 5 months ago

Ok cool - as you'll see with the number of mentions of this pull, I've done all the others too now. Thanks.

grahampugh commented 5 months ago

Wow, yes, you could have done them all in the same PR but OK! Thanks for your efforts. I'll get them merged in over the next couple of days.

rickokid commented 5 months ago

Oh true! I'm a bit new to github sorry.

grahampugh commented 5 months ago

They're all merged in now. I'll transfer them to the autopkg repo next.