search

grahampugh / jamf-upload

Scripts for uploading packages to Jamf Cloud
Apache License 2.0
148 stars 37 forks source link

JamfUploaderTeamsNotifier - MS announces retirement of Teams connectors #165

Closed jshirle2 closed 1 month ago

jshirle2 commented 1 month ago

Hello,

This is more of a question than a specific issue, but per the blog post here: https://devblogs.microsoft.com/microsoft365dev/retirement-of-office-365-connectors-within-microsoft-teams it seems that JamfUploaderTeamsNotifier will need to be changed. I was just wondering if this is in the works, etc.

Thanks!

grahampugh commented 1 month ago

I don't have any access to Teams anymore, but if this change is anything like what Slack did, it wouldn't affect the processor. It would just change how you go about creating the "Incoming Webhook" in Teams, i.e. how you generate the webhook URL.

However, I'll ping @jc0b who created this processor.

jc0b commented 1 month ago

I also don't have access to Teams anymore 😅 but yeah, as long as they haven't changed the card format it should still work.

jc0b commented 1 month ago

Yup, at a glance it appears that the webhook format still matches what you need to send Teams (although it's possible I need to switch it to an AdaptiveCard). I'll take a little look at this when I have some time, but I won't be able to test this myself.

jshirle2 commented 1 month ago

I can test it when I get a chance in its current form. I also am available to assist with any future required testing as I heavily use Teams in my current role.

jc0b commented 1 month ago

I have a copy of the processor in a fork that has been updated to use AdaptiveCard instead of MessageCard, using https://adaptivecards.io/designer/.

Two things:

Please test and let me know :)

randomName0815 commented 1 month ago

I tested it via powerautomate webhook template on a teams channel and found some small things. https://github.com/jc0b/jamf-upload/pull/1 unfortunately, i cannot test the creation of the workflow in teams due to internal guidelines. but it would probably be good to keep it backwards compatible so that everyone can switch over as soon as they are ready

randomName0815 commented 1 month ago

just tested with an old teams connector, it dont breaks it ! ... didn't expect that this would work 😅

jc0b commented 1 month ago

Yup, looks like in the docs 1.2 is the AdaptiveCard version they use. Thanks for the fix, I'll merge your changes into my fork. @grahampugh would you like more feedback on this before I open a PR?