search

grahampugh / jamf-upload

Scripts for uploading packages to Jamf Cloud
Apache License 2.0
149 stars 37 forks source link

Include Icon Path in Summary Result #79

Closed MLBZ521 closed 10 months ago

MLBZ521 commented 1 year ago

I have a wrapper around my autopkg run's and I have a use for the icon's path in that post logic. The value is already known during the Processor run, this change will simply include the policy_icon_path value in the jamfpolicyuploader_summary_results key so that it can be extracted easily.

MLBZ521 commented 10 months ago

Hey Graham, I have updated this PR to match the current code base and after looking at the code a second time....I see it could be greatly simplified, so I have done that.

If you would be willing to merge this, I could stop running a customized version finally. 😁

grahampugh commented 10 months ago

Hi, you'll need to look at the Refactor branch I'm afraid. I moved all the functions of each processor into "Base" processors to avoid so many trust-updates in the future.

MLBZ521 commented 10 months ago

Ah, I merged the latest changes in main into this old branch. I don't see a "refactor" branch....unless I'm missing something..?

grahampugh commented 10 months ago

Oh yes, I forgot that I merged the branch to main already! Cool, then it's easy. I should be able to take a look tomorrow.

MLBZ521 commented 10 months ago

Thank you sir!