search

grahams / safari-utm-stripper

Safari extension that strips Google Analytics (i.e. Urchin Traffic Monitor) tokens from URL query strings.
https://safari-extensions.apple.com/details/?id=com.dosburros.safari-utm-stripper-J3Q79T636D
48 stars 6 forks source link

Safari history not being affected by URL change/redirect? #1

Closed grahams closed 7 years ago

grahams commented 11 years ago

In Safari's history (but not in the location field), instead of the target URL, the shortened URL will show up:

http://feedproxy.google.com/~r/asdfasdf/~3/5adfasdfdsw/

Strangely enough, when I converted your extension code (charisma.js) into a user script (that I used with the NinjaKit extension), this didn't happen.

Anyway, sorry I didn't report this as an issue on GitHub, but I couldn't be bothered to create an account there.

grahams commented 11 years ago

Edited to add some tinfoil as the original reporter who "couldn't be bothered to create an account" apparently also "couldn't be bothered to censor their own tracking tokens".

Here was my original email response to the email bug report:

Google Reader uses that 'feedproxy' host and then redirects the browser to the actual URL (think of it almost as a URL shortener, though it isn't particularly short).

I'm not sure why the history gets 'fixed' in NinjaKit and not using my extension, it might just be a slight implementation difference between the two. I'm probably not going to look in to this any time soon (or possibly at all), but thanks for the report. I'll paste it into Github so it gets tracked and you can see if I ever manage to fix it (or, even better, if someone else does. :P)

grahams commented 7 years ago

We don't need to edit the history anymore thanks to @kfur's patch