search

grahams / safari-utm-stripper

Safari extension that strips Google Analytics (i.e. Urchin Traffic Monitor) tokens from URL query strings.
https://safari-extensions.apple.com/details/?id=com.dosburros.safari-utm-stripper-J3Q79T636D
48 stars 6 forks source link

Pull in changes from mihaip/utm-stripper #4

Closed liam-m closed 8 years ago

liam-m commented 9 years ago

Hey @grahams, I've been using mihaip/utm-stripper which is a fork of jparise/chrome-utm-stripper with some improvements (some of which were authored by me).

Would you be interested in including any of these improvements in this extension? The ones I can see are:

I think it would mainly be copying code from background.js to charisma.js.

The extension also has some tests you could use to verify everything works.

I'm trying to use Safari as my default browser on El Cap so anything I can do to reach extension parity with Chrome would be great. I'd be happy to implement/test any changes. I'm not currently a member of the ADP (I was a member of the Safari one but it's now been integrated to the main one, which costs money) which I think is required to be able to develop an extension.

grahams commented 9 years ago

I'll definitely take a look at what it'd take to port these changes over.... Of course, I'd also accept pull requests if you wanted to do the work yourself.

I have an ADP membership I can use to sign and release the final version of the extension.. I'm not sure if you need ADP for the develop/test cycle, though..

liam-m commented 9 years ago

That's great, thanks a lot!

I'm new to Safari extension development but it looks to me like you do:

screen shot 2015-07-13 at 09 23 35

I can't install or build package as I don't have a developer certificate.

liam-m commented 9 years ago

Made another change for YouTube URLs - https://github.com/mihaip/utm-stripper/commit/dc63613f2cdbe3db316b1fbff6fe02d5a2f04b06

grahams commented 8 years ago

A bit of a delay, but I did eventually get around to it. Let me know if there are any issues.

If the auto-update isn't working, or is slow, you can grab the latest release here: http://dosburros.com/dev/safari-utm-stripper/safari-utm-stripper-2.0.3.safariextz

liam-m commented 8 years ago
screen shot 2015-12-13 at 14 33 41
grahams commented 8 years ago

That's strange.... I just uninstalled it and reinstalled it, downloading it directly from the URL above, and other than the warning that it didn't come from the apple gallery it installed fine... Hrm.

grahams commented 8 years ago

@liam-m Even more strange is that a friend was also just able to install it on his machine.. Maybe download and try again?

liam-m commented 8 years ago

Autoupdate hadn't picked up the new version and I was trying to get it to update by installing it. Uninstalling and reinstalling worked so I assume it isn't able to update by installing on top - i.e. you can't install an extension that you already have an older version of.

liam-m commented 8 years ago

Just noticed the YouTube ones aren't working for me - do they work for you?

grahams commented 8 years ago

I just pushed a new version, 2.0.4, let me know if it helps...

http://dosburros.com/dev/safari-utm-stripper/safari-utm-stripper-2.0.4.safariextz

(Autoupdate should also get you the new version).

liam-m commented 8 years ago

That seems to be working :)