search

grahamwhaley / DSPham

A Teensy based DSP audio processor
GNU General Public License v3.0
24 stars 7 forks source link

Settings: save slot does not save name #19

Closed grahamwhaley closed 2 years ago

grahamwhaley commented 3 years ago

There seem to be at least a couple of things wrong with the 'save settings'.

I was trying to 'clone' an existing slot and change the active NR. I selected CW (slot 5), set the slot number in the settings menu and set the name, and changed the NR algo from none to LLMS. Then I saved into slot7. When then re-selecting slot7, the name was blank and the NR was not set...

Looking at the code, it seems that saveSettings() does not save the name, which looks to be a bug. Should be an easy fix?

I've not worked out why the NR did not get set - that might require some actual debug...

grahamwhaley commented 2 years ago

Looks like this is not an issue. Although the code did appear not to copy over the name to save, that is because the name was already in the slot from when it was loaded or edited.

I probably 'saw' the issue whilst having a version mismatch during development, which causes name save/load issues.

I've added a comment to the code noting that the name field is valid and saved.