search

grai-io / grai-core

https://www.grai.io
Other
293 stars 20 forks source link

[GRA-909] Add html to email for verification #702

Closed edlouth closed 1 year ago

edlouth commented 1 year ago

Current email template is at https://github.com/grai-io/grai-core/blob/af7a53ff85e0cd8b47698aca55f44897d9f583b6/grai-server/app/templates/auth/email_verification.txt but is text only, would be nice to add an html template.

I presume that Django has an off the shelf way to do this.

The current email could be improved with more text, sign off and so on.

GRA-909

KunalDhand commented 1 year ago

hey @edlouth, can I do this?

edlouth commented 1 year ago

@kunaldhand it is great to hear that you are interested in working on this issue. Please go head, you should now be assigned to the issue. If you need any pointers or help, please let me know.

KunalDhand commented 1 year ago

email_template_example The Email Template I designed will look like this. Is this OK?

KunalDhand commented 1 year ago

email_template_example The Email Template I designed will look like this. Is this OK?

One more thing, do you want inline css or a different file of css>

edlouth commented 1 year ago

That looks great, inline css would probably be easiest.

KunalDhand commented 1 year ago

I have submitted a pull request kindly revise it and merge it @edlouth .

KunalDhand commented 1 year ago

Are we done here @edlouth ? You merged the proposed pull request, so I believe this issue is fixed now. One more thing, this project is also missing a password reset email template. If you want I can make that template too. You can open a new issue and assigned it to me, if you like.

edlouth commented 1 year ago

Yes this is all done, I have linked the PR and will close. I will open a new ticket for the password reset email, it would be great if you could take a look.

KunalDhand commented 1 year ago

Yes this is all done, I have linked the PR and will close. I will open a new ticket for the password reset email, it would be great if you could take a look.

Sure, It would be great if you assign the new ticket of Password Verification Template to me, whenever you open it.