grailbio / base

A collection of Go utility packages used by GRAIL's tools
Apache License 2.0
89 stars 25 forks source link

Minor bug in s3file.go causes unnecessary requests to s3 #1

Closed guliyevemil1 closed 5 years ago

guliyevemil1 commented 5 years ago

In s3file.go, on line 574, we have

    if newPosition == f.position {
        req.ch <- response{off: f.position}
    }

and it looks like the intended code was supposed to have a return statement like this:

    if newPosition == f.position {
        req.ch <- response{off: f.position}
        return
    }
yasushi-saito commented 5 years ago

Yes, you are right. Thanks for pointing out.