search

grailbio / base

A collection of Go utility packages used by GRAIL's tools
Apache License 2.0
89 stars 25 forks source link

Guard nil HeadObjectOutput fields #17

Closed jcharum closed 4 years ago

jcharum commented 4 years ago

See https://github.com/grailbio/base/pull/14#issuecomment-622098407 for context.

jcharum commented 4 years ago

@josh-newman: Could you take another look? I applied the same guards to (*s3Impl).Stat, refactoring along the way.

tatatodd commented 4 years ago

Thanks very much folks for the fix!

If it's easy, can you create a v0.0.8 release at some point? We'll use a commit hash in our go.mod in the meantime, but it'd be nice to be on a tagged release. :)

jcharum commented 4 years ago

If it's easy, can you create a v0.0.8 release at some point?

https://github.com/grailbio/base/releases/tag/v0.0.8

tatatodd commented 4 years ago

Awesome, thank you!