Upgrade dependencies to fix build errors with recent versions

grailbio / base

A collection of Go utility packages used by GRAIL's tools

Apache License 2.0

89 stars 25 forks source link

Upgrade dependencies to fix build errors with recent versions #22

Closed matthewloring closed 4 years ago

jcharum commented 4 years ago

Hi @matthewloring! Thanks for the PR. I'm looking into the CI build failures. At least one of them is because we pushed internal changes that are no longer 1.12 compatible, so I will do something about that. I haven't yet had a chance to look into 1.13 build failures but will get to it today (though I'd welcome help understanding them!). Thanks again.

matthewloring commented 4 years ago

Thanks for taking a look @jcharum! Unfortunately, env GO111MODULE=on go test -tags=unit ./... passes for me locally so I'm not able to reproduce the 1.13 failures. error: grail-access.test: /home/travis/.v23 is not a directory looks like a vanadium issue, I can take a look tomorrow.

jcharum commented 4 years ago

@matthewloring : We're having a look internally, so don't worry too much about it. I know very little about Vanadium, though, so I'm enlisting in some other folks in GRAIL. You might be able to reproduce by removing $HOME/.v23 and then trying to run the test. If we can't resolve tomorrow, we might be okay merging over the broken build, but I'd like to avoid that if possible. Thanks!

matthewloring commented 4 years ago

@jcharum I don't seem to have a $HOME/.v23 directory locally and the tests still pass locally after creating it.

jcharum commented 4 years ago

@matthewloring: Thanks for checking. I've chased down the various build problems. They boil down to these things:

Need to drop support for Go 1.12 (https://github.com/grailbio/base/pull/23).
Need to build on xenial (https://github.com/grailbio/base/pull/25).
Need to stop setting V23_CREDENTIALS environment variable. (This is the cause of the $HOME/.v23 panic/test failure).

Could you merge master to make sure that everything is copacetic? Thanks!

jcharum commented 4 years ago

Yay; builds passed.

matthewloring commented 4 years ago

Thank you for fixing the other build breakages!

matthewloring commented 4 years ago

Thanks for your help! Will you be able to do a new release of grailbio/base?

jcharum commented 4 years ago

Thanks for your help! Will you be able to do a new release of grailbio/base?

Thank you for the PR! I'm looking through the changes now, so it should be done shortly.

jcharum commented 4 years ago

Thanks for your help! Will you be able to do a new release of grailbio/base?

Done: https://github.com/grailbio/base/releases/tag/v0.0.10.

matthewloring commented 4 years ago

Thanks!!