search

grailbio / base

A collection of Go utility packages used by GRAIL's tools
Apache License 2.0
89 stars 25 forks source link

Use `unix.IoctlGetWinsize` instead of direct system call #26

Closed jcharum closed 3 years ago

jcharum commented 4 years ago

In the status package, we make a system call to get the terminal window size.

As of Go 1.12, Go uses libSystem to make system calls. unix.SYS_IOCTL no longer exists as of this commit.

I think that system call should be replaced with a call to unix.IoctlGetWinsize.

jcharum commented 3 years ago

This was fixed as part of https://github.com/grailbio/base/pull/22.