grailbio / bigslice

A serverless cluster computing system for the Go programming language
https://bigslice.io/
Apache License 2.0
550 stars 35 forks source link

Guard nil error maybeTaskFatalErr construction #114

Closed jcharum closed 4 years ago

jcharum commented 4 years ago

Otherwise, you get a very confusing error message like:

inv1_const_map_scan@2:1 error: %!v(PANIC=Error method: runtime error: invalid memory address or nil pointer dereference)

This is because we construct a (non-nil) maybeTaskFatalErr error that holds a nil error. The error gets swallowed by reviseSeverity, so this shouldn't change computation behavior, but we've already printed the confusing error by then.