search

grailbio / reflow

A language and runtime for distributed, incremental data processing in the cloud
Apache License 2.0
965 stars 52 forks source link

reflow/eval: resolve unresolved files before comparing them #117

Closed prasadgopal closed 4 years ago

prasadgopal commented 4 years ago

In the scheduler mode, we delay interning files to when execs need them. This means if we try to compare two files, one that is a result of an exec and one that isn't dependent on an exec, we end up with two files where one is fully resolved and the other isn't.

This diff changes the behavior to panic if we ever compare a resolved file and an unresovled one.

We now force file resolution when we try to compare two files where one is resolved and the other isn't.

prasadgopal commented 4 years ago

volume watcher tests are still failing on osx. I would recommend we commit this as is and take up that issue in a separate diff. LMK.

prasadgopal commented 4 years ago

@mariusae Let me know if I can merge this. Also do we need the go: master job in travis? I think that is what is failing right now complaining about something in v.io.