search

grailbio / reflow

A language and runtime for distributed, incremental data processing in the cloud
Apache License 2.0
965 stars 52 forks source link

Always close spot instance action response body #122

Closed jcharum closed 4 years ago

jcharum commented 4 years ago

Always close the body of the spot instance action HTTP request. The existing code does not close the response body on nil-error, non-OK responses.

jcharum commented 4 years ago

Closing it just after the error doesn't work because we might eventually read it, but you're right that we should close it in every iteration of the loop (duh). It's better now; sorry about the hiccup.