search

grailbio / reflow

A language and runtime for distributed, incremental data processing in the cloud
Apache License 2.0
965 stars 52 forks source link

Simplify return type of (Path).Match #124

Closed jcharum closed 4 years ago

jcharum commented 4 years ago

Simplify the return type of (Path).Match by eliminating the redundant bool returned from (Path).Match. The bool indicated whether the path matched, but this is already communicated as a non--nil error.

Make the return values consistent and easier to interpret. If there is a match, the error is nil and the other fields are populated. If there is no match, error is non-nil and the other fields are nil.

jcharum commented 4 years ago

I was cleaning up old local branches, and I came across this, so I finished it up and am submitting it now.