search

graileddotcom / grailed

4 stars 0 forks source link

Additional currency #1

Open graileddotcom opened 9 years ago

graileddotcom commented 9 years ago

Every time the item is edited it's reverted to dollars FIXED, changed to question/discussion about the feature

albo-cadd9 commented 9 years ago

Also imo would make more sense having it as a global variable instead of selecting it for every item

albo-cadd9 commented 9 years ago

@muffs @liamgriffiths So what's the status for this? A buyer just told me he wants to pay in € if possible, but he can't. It's quite annoying since I feel like I'm donating money to paypal :| (I'm in the eurozone btw)

julianlconnor commented 9 years ago

@albo-cadd9 This bugfix will go out on Monday ;)

albo-cadd9 commented 9 years ago

Oh I see you've implemented it, great! Before closing it, one question: I tried paying for a 300 USD item in EUR, and it converted the amount to 267.59€, which is (according to google) 295.26 USD. So it uses a 0.89 rate (paypal's rate) instead of the real 0.91. So basically if I ask a buyer to pay in dollars or euro it doesn't make any difference to me, how's that? What am I missing?

ArunGupta25 commented 9 years ago

This is what we use to get our exchange rate: https://openexchangerates.org/. It's not paypal.

albo-cadd9 commented 9 years ago

Ok, I didn't mean you used paypal's currency conversion, just that the rate is the same. Bloomberg actually agrees with google on this.

image

Anyway I'm not gonna bother you guys with this any further.

ArunGupta25 commented 9 years ago

Are you sure it converted it to 267.59 euro? I just checked our currency conversion function and it gave me 271.96 euro for 300 USD.

On Aug 18, 2015, at 4:33 PM, albo-cadd9 notifications@github.com wrote:

Ok, I didn't mean you used paypal's currency conversion, just that the rate is the same. Bloomberg actually agrees with google on this.

https://cloud.githubusercontent.com/assets/13737234/9341841/8d758ed0-45f8-11e5-8ad2-4b7aedfb28b6.png Anyway I'm not gonna bother you guys with this any further.

— Reply to this email directly or view it on GitHub https://github.com/graileddotcom/grailed/issues/1#issuecomment-132342190.

albo-cadd9 commented 9 years ago

you're right, I fucked up my math, thanks for your patience (maybe that's why I'm a designer and not a coder). Anyway, glad to see that now it's working well!

Any chance of putting it as a global variable instead of selecting it every time for every item? Would be handy also for people who already have a big wardrobe and want to enable the additional currency.

albo-cadd9 commented 9 years ago

I'm trying to edit my old items (listings made before the change went live) to use € but they keep reverting to $.

albo-cadd9 commented 9 years ago

also buyers can't make an offer in currencies other than dollars