search

grails-samples / grails-website

Grails Web Site
157 stars 174 forks source link

Changes made to README and Tests (making them pass) #7

Closed coderberry closed 10 years ago

coderberry commented 12 years ago

Here are my changes which include test fixes and updated README.markdown.

I did check in a bunch of changes on the IML files. Please let me know if you would like me to resubmit without these changes.

Thanks!

kenliu commented 11 years ago

Peter - is this pull request ready to be merged? Would it be helpful to break this down into smaller pull requests that could be merged individually?

kenliu commented 11 years ago

BTW this pull request has been open for a year.

kenliu commented 11 years ago

I took a closer look at this changeset and it looks like this needs to be broken down into different pull requests. I'll go ahead and submit the separate pull requests and then request for this one to be closed.

kenliu commented 11 years ago

Upon further inspection it seems that all of the changes related to the pull request have been merged into master and so this pull request can be closed.

graemerocher commented 10 years ago

Don't think this is relevant anymore. Thanks for all the subsequent contributions though!