docs - multi-datasource config inconsistency

[zyro23]

configuring two dataSources,

• https://github.com/grails/gorm-hibernate5/blob/v6.0.8/docs/src/docs/asciidoc/multipleDataSources/configuration.adoc says

  dataSource:
  # primary dataSource config ("dataSource")
  dataSources:
  secondary:
      # secondary dataSource config ("dataSource_secondary")

  is the correct format while

• http://docs.grails.org/3.2.6/guide/conf.html#multipleDatasources
• https://github.com/grails/grails3-functional-tests/blob/3.2.x/datasources/grails-app/conf/application.yml
• https://github.com/grails/gorm-hibernate5/blob/v6.0.8/grails-datastore-gorm-hibernate5/src/main/groovy/grails/orm/bootstrap/HibernateDatastoreSpringInitializer.groovy#L93

indicate that the correct format is:

dataSources:
    dataSource:
        # primary dataSource config ("dataSource")
    secondary:
        # secondary dataSource config ("dataSource_secondary")

[graemerocher]

the former is correct. pull requests welcome

[zyro23]

just making sure i get that one right - by "former is correct" you mean

dataSources:
    dataSource:
        # primary dataSource config ("dataSource")
    secondary:
        # secondary dataSource config ("dataSource_secondary")

and the pull request should update the gorm-hibernate5 docs reflecting that format?

[graemerocher]

No.

dataSource:
    # primary dataSource config ("dataSource")
dataSources:
    secondary:
        # secondary dataSource config ("dataSource_secondary")

Is correct. Since typically you have a single default data source and multiple other data sources that inherit settings from the default.

[zyro23]

just a quick note that this is still on the radar, however i am currently using the "legacy" syntax succesfully with gorm-6.1.1 and that is the only working one, at least until https://github.com/grails-plugins/grails-database-migration/commit/754ad2fb7fdc41160258807695b0f4d80cf16577 is released.