lucas-napse
commented
1 year ago @puneetbehl I have the changes of MongoEntityPersister in my ide. Do you want me to upload it as a pull request?
The change: OLD
if (embeddedInstances instanceof Collection) { // true
Collection coll = (Collection)embeddedInstances;
for (Object dbo : coll) { // for each embedded element...
if (dbo instanceof Document) { // <------ this condition is problematic: is a Map, not a Document
Document nativeEntry = (Document)dbo;NEW
if (embeddedInstances instanceof Collection) {
Collection coll = (Collection)embeddedInstances;
for (Object dbo : coll) {
if (dbo instanceof Map) { // Map, instead Document, in this section
Document nativeEntry;
if(dbo instanceof Document){ // then, it is a Document? then the same thing
nativeEntry = (Document)dbo;
}
else{
nativeEntry = new Document((Map)dbo); // if it is a Map, a new Document instance is created based on that Map.
}OLD EDIT:
@puneetbehl I cant upload this PR, the server returns 403 "no permission" when i try to push to branch 73x.
NEW EDIT. IMPORTANT!
This is not the solution. The solution is found below, in the modification of the getValue() method
seanhastings
puneetbehl
mgm7734
practical-programmer
AntonioAure
carlosorrego
Hi @puneetbehl !
In our system we have a large number of domain classes. In our recent upgrade to grails 5 (5.3.2) that makes use of GORM 7.3.0 of our system, which was working fine with the Grails 2.5.6, we noticed that the embedded entities were not loaded in the object that contained it: For example,
In the above
Countryhas embeddedregions, these regions are initialized as anempty listwhen loaded through GORM. Whereas, in the database collectionCountryhasregions. Even, when using the MongoDB API, these regions are loaded correctly as list ofDocument.This does not work when using either
Country.findAll(), orCountry.createCriteria().list{}. It maybe breaking with other GORM queries as well.Upon, debugging, we noticed that the problem might be caused because the database returns a
Mapinstead of aDocument. The Groovy classMongoEntityPersisterexclusively checks for the classDocumentwhich breaks certain conditions. For example:MongoEntityPersister.loadEmbeddedCollection().When the method is executed, I noticed that in our case it goes through the
elsebranch because the following condition evaluates tofalseThe above results in embedded
regionsto return an emptyListbecause it is aMap.By modifying the above to following, might fixes the problem:
The above change solves the our problem where the
regionsare correctly loaded via the GORMCountry.findAllmethod.Doing more tests I notice that there is a second problem: if this embedded entity uses composition, some related attributes are loaded and others are not. For example: my country has regions, and a region has a region type. This type of region is a Domain. The regions are embedded in the country, and a region has only one type of region, as an associated instance (composition).
This instance, the region type, is not loaded.
Performing more debugging, I find that the code goes by: NativeEntityPersister#refreshObjectStateFromNativeEntry(PersistentEntity, Object, Serializable, T, boolean)
... continuing debugging leads to this method ...
... continuing debugging leads to this method ...
...clearly this method gives true when it is a Document, but my region type appears as Map, which gives false. This, by giving false, the caller (AbstractMongoObectEntityPersister#getEmbedded(T, String)) determines that it is null, so it does not load my region type.
Making this change should fix it:
The problem now is that internally we get various errors related to the Map and Document type. And these are related to the getValue() and setValue() methods of the MongoEntityPersister class:
This is the error you get after making all the changes I mentioned above:
As a solution we will try to use an older version of gorm, but if this problem can be solved it would be great since it is always necessary to have the latest. If you need more information, please comment and I will respond as soon as possible.
Some details: | Grails Version: 5.3.2 | JVM Version: 11.0.16.1 | Gorm version: 7.3.0 | Windows 11, with last updates.
(build.gradle) implementation 'org.grails.plugins:mongodb:7.3.0' implementation "org.grails:gorm-mongodb-spring-boot:7.3.0"