GRAILS-12045: Specifiying a layout in a controller or layout by convention does not work

graemerocher commented 9 years ago

Original Reporter: benorama Environment: Mac OSX 10.10.2 Version: 3.0-M2 Migrated From: http://jira.grails.org/browse/GRAILS-12045

It looks like there is some issue when trying to specify layout per controller or when using layout by convention.

To reproduce the issue:

grails create-app foo-app
grails create-controller foo
create views/foo/index.gsp
create views/layout/foo.gsp
update FooController.index() to return an empty map
grails run-app
go to http://localhost:8080/foo/index

Or run the provided foo-app.

The foo.gsp layout by convention is not applied. I've also tried to specify the layout at the controller level with static layout = 'bar'but it did not work.

The only workaround I found was to specify the layout in the view with <meta name="layout" content="foo" />.

Did I miss some changes in the way Grails 3 handle layouts and views? Or the docs are not yet updated (http://grails.github.io/grails-doc/3.0.x/guide/theWebLayer.html#layouts) ?

Thanks!

graemerocher commented 9 years ago

brownj said: The fix for GRAILS-12038 (https://github.com/grails/grails-core/commit/140a60b268d4ed150c8f342a4cc56bbb9bbeb9c9#diff-4d0cafafb9cec54782580b94eab606caR65) also fixes this issue. There are now relevant functional tests at https://github.com/grails/grails3-functional-tests/commit/7083b841acd1acb17efe87b7f9457d3d8f94f6bf.

graemerocher commented 9 years ago

brownj said: The attached grails12045.zip contains a project which renders a view which uses a custom layout and the view renders without an error. I will try to isolate the problematic scenario which causes the error you mentioned. If you can provide any details on how to create the problem or a sample app, I would appreciate it. Thanks for the feedback.

grails / grails-core

GRAILS-12045: Specifiying a layout in a controller or layout by convention does not work #2183