grails / grails-database-migration

Grails® framework Database Migration Plugin
Apache License 2.0
98 stars 115 forks source link

Upgrade to Liquibase 3.10.1 (also liquibase-hibernate5) #175

Closed robertoschwald closed 4 years ago

robertoschwald commented 4 years ago

Tested successfully with Grails 4.0.3 in a fairly complex project.

puneetbehl commented 4 years ago

Thank you for the PR, can you please remove the spacing changes from the PR?

robertoschwald commented 4 years ago

I can. Isn't it better readable when indention is correct? With the PR it does not matter anymore, as spaces are removed before comparison anyway.

davydotcom commented 4 years ago

It probably would be easier not to change some of the indentations like the Specs where the quoted multiline strings have extra indentation. This affects the final string output.

robertoschwald commented 4 years ago

It doesn't matter as I've written, as all blanks are removed from the fixtures and the output before comparison to make the tests more robust, but I will change it back on your request.

puneetbehl commented 4 years ago

I am not very sure but I think there are issues while tracing the history or resolving conflicts where the whitespaces/indentation creates some confusion. So, I would prefer to avoid the changes from this specific PR, we can create another PR specific to those changes.

robertoschwald commented 4 years ago

Done. If you like me to squash commits, feel free to comment.

puneetbehl commented 4 years ago

I will squash it directly while merging, thanks!