grails / grails-database-migration

Grails® framework Database Migration Plugin

Apache License 2.0

98 stars 115 forks source link

#163 added new Liquibase column parameters to gdsl #178

Closed robertoschwald closed 4 years ago

robertoschwald commented 4 years ago

163

These fields are supported since Liquibase 3.1 / 3.4:

beforeColumn
afterColumn
position
descending

puneetbehl commented 4 years ago

Can you please also add the tests?

robertoschwald commented 4 years ago

I can, but its GDSL only change.
Do we have any test for column parameters, yet?

bobbywarner commented 4 years ago

@puneetbehl @robertoschwald We do not have any tests for GDSL currently that I can see in the project (unless I'm missing something). We can certainly work on adding tests for GDSL if desired going forward, but I don't think we should delay this pull request for implementing those new tests.

So, going to merge this as-is because these fields are supported as per Lliquibase documentation: https://docs.liquibase.com/concepts/advanced/column.html