grails / grails-gradle-plugin

Apache License 2.0
6 stars 9 forks source link

fix(build): Cleanup dependency management #273

Closed matrei closed 6 months ago

matrei commented 6 months ago

All dependencies were declared with the api scope which is not necessary and which leaks dependencies to downstream projects. After this change it should no longer be necessary for Grails apps to force the version of groovy-xml. Several unused dependencies have also been removed.

matrei commented 6 months ago

@puneetbehl I have now tested this pull request on https://github.com/grails/grails-functional-tests by:

And the build runs without issues. (The only thing I needed to change was geb/selenium/webdriver versions/config to be able to run the integration test suite it on my computer.)

I have also previously successfully built https://github.com/grails/grails-spring-security-core (which also has several grails apps for testing) with these changes. In this project there is also code in buildSrc/src/main/groovy which would not compile without forcing groovy-xml:3.0.13. With the changes in this branch the forcing can be removed.