Plugin update for grails version 6.1.1 and jdk 11

grails / grails-quartz

This project provides integration of the Quartz scheduling framework into the Grails Framework

http://grails.org/plugin/quartz

Apache License 2.0

76 stars 90 forks source link

Plugin update for grails version 6.1.1 and jdk 11 #120

Closed fernando88to closed 6 months ago

fernando88to commented 9 months ago

Tasks that were done

This pull request presents a comprehensive refactoring of our plugin's unit tests, with the aim of ensuring full compatibility with the latest version of Grails.
Plugin update for grails version 6.1.1 and jdk 11
Create command for create-job
update documentation

Steps that remain to be taken

Generate documentation
Configure application publication

puneetbehl commented 9 months ago

@Richardson-e Could you please review this pull-request?

dauer commented 8 months ago

I ran into an issue with the 2.0.13 version of the Quartz plugin when upgrading from Grails 4.1.1 -> 6.1.1, so I tried building a local version from @fernando88to branch and that fixed my failing tests - so it looks very promising!

Only thing is that when doing a gradle publishToMavenLocal the jar file had -plain added to the filename: quartz-2.0.14.BUILD-SNAPSHOT-plain.jar Expecting: quartz-2.0.14.BUILD-SNAPSHOT.jar

CLAassistant commented 6 months ago

All committers have signed the CLA.

CLAassistant commented 6 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

puneetbehl commented 6 months ago

@matrei Can you please look into this?

matrei commented 6 months ago

@matrei Can you please look into this?

@puneetbehl There is some overlap with #125. @fernando88to Good with a rewrite of the tests to spock 👍 . Can you create a new PR based on 3.0.x with only those?

fernando88to commented 6 months ago

@matrei Can you please look into this?

@puneetbehl There is some overlap with #125. @fernando88to Good with a rewrite of the tests to spock 👍 . Can you create a new PR based on 3.0.x with only those?

I am going to do