grails / grails-spring-security-cas

Apache License 2.0
19 stars 29 forks source link

CAS configuration once loaded overrides the other application configuration #27

Open EshaanKumar opened 5 years ago

EshaanKumar commented 5 years ago

The code in SpringSecurityCasGrailsPlugin - loads "DefaultCasSecurityConfig"

`SpringSecurityUtils.loadSecondaryConfig 'DefaultCasSecurityConfig'
        // have to get again after overlaying DefaultCasSecurityConfig
        conf = SpringSecurityUtils.securityConfig

        if (!conf.cas.active) {
            return
        }`

And in "DefaultCasSecurityConfig" there are default CAS configuration which are now loaded whenever the Plugin is included irrespective the active flag is true of false.

In similar line there is SAML plugin SpringSecuritySamlGrailsPlugin. The above mentioned code is commented.

Code in the CAS plugin need to be commented too. This will ensure that default CAS configuration wouldn't be loaded by default whenever this plugin is included.

KoloritnijClap commented 4 years ago

Load secondary config method user merge config. Here it is description about it: /**