Open dlehammer opened 6 years ago
@jeffbrown
I sorry, but I must be missing something, the referenced GradleUtil.groovy
doesn't refer to grailsWrapperVersion
.
(however it does reference gradleWrapperVersion :) in line 59)
You are correct. My mistake. I didn't read closely enough. I am sorry for the noise.
This is by design. It was put there in order to determine if there is an updated version of the wrapper. In practice that feature was never used and turned out to be probably not the best idea.
Symptom discovered during migration of web-application from Grails v2.4.4 to v3.3.5, symptom still present in Grails v3.3.8.
Task List
Steps to Reproduce
create a Grails app (symptom is also present for plugins etc.)
commit
create-app
to version control, ex. using Git.execute a Gradle/Grails command, ex.
-version
where side-effects are unexpected (symptom is also present forcreate-service
etc.)now
gradle.properties
has been modified.Expected Behaviour
gradle.properties
isn't expected to be modified by Gradle/Grails after initialcreate-app
.The Grails wrapper is expected to be self-contained, ie. it's unexpected that redundant configuration leaks into
gradle.properties
. In my experience thegrailsWrapperVersion
isn't needed in-order for Gradle/Grails wrapper to function as expected.Actual Behaviour
gradle.properties
is modified by Gradle/Grails, se also Steps to ReproduceWork-around(s)
A. explicitly add the
grailsWrapperVersion=1.0.0
togradle.properties
and commit.B. mark
gradle.properties
as readonly.Environment Information