search

grainger-illinois / CTCast

Apache License 2.0
0 stars 0 forks source link

Fixed chunkstring and sendMessage functions in api.js #14

Closed romerorisa closed 1 year ago

romerorisa commented 1 year ago

Added a set of parantheses on line 205 to fix the output text of the link encoder. Also changed chunkstring function to return the correct thing.

angrave commented 1 year ago

Addresses long message Encoder Bug (Issue #12) and also reduces some but not all differences between this code and the python code (Issue #7). e.g. No delays not yet implemented.

The code could benefit from better refactoring; e.g. there's no way to write a good test case because the send logic is intermingled with chopping up the message. (Dependency injection and putting the sentence splitting into a testable function would alot help here)

angrave commented 1 year ago

Merged! (You can delete this branch if no longer using it) In the future- Please create branch names based on the bug or feature that you are working on. Ideally please reference the github issue number(s) (bug/feature) in the commit and the PR request.

romerorisa commented 1 year ago

Got it.