search

grainger-illinois / CTCast

Apache License 2.0
0 stars 0 forks source link

updated npm deprecated packages #57

Closed evam3illinois closed 1 year ago

evam3illinois commented 1 year ago

I had problems with the commit. What I changed was the package.json. I will try to commit it again with the new changes.

Enviado desde mi iPad

El nov. 4, 2022, a las 14:07, Lawrence Angrave @.***> escribió:



@angrave requested changes on this pull request.

There are no files in this commit!? Did you forget to add requirements.txt?

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/grainger-illinois/CTCast/pull/57*pullrequestreview-1169080397__;Iw!!DZ3fjg!9J9v9x3rs51D82jRXy6JaBP35RmGhkHQzWpK_1Kv-xQJWMr9vbP_77LDmb1I1Up4sCBpOg9m_BMv0TJtXrnkG2wrKA$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A23AZG3TDJQZDHAXJQUPL23WGVNGZANCNFSM6AAAAAARXHUBO4__;!!DZ3fjg!9J9v9x3rs51D82jRXy6JaBP35RmGhkHQzWpK_1Kv-xQJWMr9vbP_77LDmb1I1Up4sCBpOg9m_BMv0TJtXrnbELI9kA$. You are receiving this because you authored the thread.Message ID: @.***>

angrave commented 1 year ago

CI Build is broken.I believe this is something you can reproduce locally?

2022-11-07T17:32:42.6483533Z Expected plugin to either be a plugin instance or a { name, config } object but found @electron-forge/plugin-webpack,[object Object] 2022-11-07T17:32:42.6484482Z Error: Expected plugin to either be a plugin instance or a { name, config } object but found @electron-forge/plugin-webpack,[object Object] 2022-11-07T17:32:42.6485366Z at /home/runner/work/CTCast/CTCast/node_modules/@electron-forge/core/dist/util/plugin-interface.js:39:19 2022-11-07T17:32:42.6486188Z at Array.map () 2022-11-07T17:32:42.6486969Z at new PluginInterface (/home/runner/work/CTCast/CTCast/node_modules/@electron-forge/core/dist/util/plugin-interface.js:21:44) 2022-11-07T17:32:42.6487710Z at Object._default [as default] (/home/runner/work/CTCast/CTCast/node_modules/@electron-forge/core/dist/util/forge-config.js:157:43) 2022-11-07T17:32:42.6488322Z at async /home/runner/work/CTCast/CTCast/node_modules/@electron-forge/core/dist/api/make.js:64:23

angrave commented 1 year ago

Please can you rebase on the current staging branch and do a new PR? Be sure to preserve any remote changes; don't just overwrite everything with your local changes. (you will need to fetch or pull the staging branch to get the changes locally).