Iss47

[jcmoore2]

This adds clearer error handling to api.js, now when a message is left blank or you are not connected to the server the software will let the user know that their message was blank or that they are not connected to the server. Initially handled this in Linkencoder.js but changed to api.js because it was cleaner.

[angrave]

CI build failed - 1) basic_tests.spec.ts:130:1 › renders the zoom page ============================================= 2022-11-07T18:20:27.1507290Z 2022-11-07T18:20:27.1507920Z Test timeout of 30000ms exceeded. 2022-11-07T18:20:27.1508360Z 2022-11-07T18:20:27.1509060Z frame.waitForSelector: Target closed 2022-11-07T18:20:27.1509980Z =========================== logs =========================== 2022-11-07T18:20:27.1510640Z waiting for selector "h1" to be visible 2022-11-07T18:20:27.1511450Z ============================================================ 2022-11-07T18:20:27.1511880Z 2022-11-07T18:20:27.1512690Z 135 | page.locator('a:has-text("Zoom")').click() 2022-11-07T18:20:27.1513310Z 136 | ]); 2022-11-07T18:20:27.1514540Z > 137 | await window.waitForSelector('h1') 2022-11-07T18:20:27.1518170Z | ^ 2022-11-07T18:20:27.1518980Z 138 | const text = await page.$eval('h1', (el) => el.textContent) 2022-11-07T18:20:27.1519580Z 139 | expect(text).toBe('Zoom') 2022-11-07T18:20:27.1519940Z 140 | page = window.page() 2022-11-07T18:20:27.1521950Z

[angrave]

I expect these changes are still being tested with the old test code of the staging branch. (i.e. 30s) Did you try making a github action on your own branch to test it.

[angrave]

From the github action log you can see it timedout > 30s. So I propose I accept these changes even though they failed to build. Thoughts?

1) basic_tests.spec.ts:130:1 › renders the zoom page =============================================
2022-11-17T01:05:45.9384248Z 
2022-11-17T01:05:45.9384564Z     Test timeout of 30000ms exceeded.
2022-11-17T01:05:45.9384812Z 
2022-11-17T01:05:45.9385044Z     frame.waitForSelector: Target closed
2022-11-17T01:05:45.9385433Z     =========================== logs ===========================
2022-11-17T01:05:45.9385823Z     waiting for selector "h1" to be visible
2022-11-17T01:05:45.9386184Z     ============================================================
2022-11-17T01:05:45.9386451Z 
2022-11-17T01:05:45.9386768Z       134 |     page.locator('a:has-text("Zoom")').click()
2022-11-17T01:05:45.9387081Z       135 |   ]);
2022-11-17T01:05:45.9387480Z     > 136 |   await window.waitForSelector('h1')
2022-11-17T01:05:45.9387785Z           |                ^
2022-11-17T01:05:45.9388307Z       137 |   const text = await page.$eval('h1', (el) => el.textContent)
2022-11-17T01:05:45.9388746Z       138 |   expect(text).toBe('Zoom')
2022-11-17T01:05:45.9389081Z       139 |   page = window.page()
2022-11-17T01:05:45.9389296Z 
2022-11-17T01:05:45.9389580Z         at /home/runner/work/CTCast/CTCast/testing/basic_tests.spec.ts:136:16
2022-11-17T01:05:45.9390093Z         at /home/runner/work/CTCast/CTCast/node_modules/@playwright/test/lib/workerRunner.js:426:9
2022-11-17T01:05:45.9390671Z         at TestInfoImpl._runFn (/home/runner/work/CTCast/CTCast/node_modules/@playwright/test/lib/testInfo.js:166:7)
2022-11-17T01:05:45.9393827Z         at /home/runner/work/CTCast/CTCast/node_modules/@playwright/test/lib/workerRunner.js:376:26
2022-11-17T01:05:45.9394578Z         at TimeoutRunner.run (/home/runner/work/CTCast/CTCast/node_modules/playwright-core/lib/utils/timeoutRunner.js:53:14)
2022-11-17T01:05:45.9395234Z         at TimeoutManager.runWithTimeout (/home/runner/work/CTCast/CTCast/node_modules/@playwright/test/lib/timeoutManager.js:73:7)
2022-11-17T01:05:45.9395878Z         at TestInfoImpl._runWithTimeout (/home/runner/work/CTCast/CTCast/node_modules/@playwright/test/lib/testInfo.js:154:26)
2022-11-17T01:05:45.9396489Z         at WorkerRunner._runTest (/home/runner/work/CTCast/CTCast/node_modules/@playwright/test/lib/workerRunner.js:356:5)
2022-11-17T01:05:45.9397810Z         at WorkerRunner.runTestGroup (/home/runner/work/CTCast/CTCast/node_modules/@playwright/test/lib/workerRunner.js:218:11)
2022-11-17T01:05:45.9398708Z         at process.<anonymous> (/home/runner/work/CTCast/CTCast/node_modules/@playwright/test/lib/worker.js:88:5)
2022-11-17T01:05:45.9399020Z 
2022-11-17T01:05:45.9399284Z   Slow test file: basic_tests.spec.ts (31s)
2022-11-17T01:05:45.9399708Z   Consider splitting slow test files to speed up parallel execution
2022-11-17T01:05:45.9399974Z 
2022-11-17T01:05:45.9400120Z   1 failed
2022-11-17T01:05:45.9400651Z     basic_tests.spec.ts:130:1 › renders the zoom page ==============================================
2022-11-17T01:05:45.9400998Z   6 passed (38s)