Closed shubhamk008 closed 1 year ago
I think I figured out what was causing the issue. In my local tests I have the test server running, so everything passes. In the github actions the server isn't running, so the test times out when trying to click the submit button because it is trying to send the request to a server that isn't running. I modified the test cases to fix this and pushed to testing. I also updated the ReadMe
Btw using the actions tab you should be able to re-run the build manually on GitHub.com for the staging branch or your branch.
From: Timmy Sullivan @.> Sent: Friday, October 28, 2022 4:27:37 PM To: grainger-illinois/CTCast @.> Cc: Angrave, Lawrence @.>; Comment @.> Subject: Re: [grainger-illinois/CTCast] Build scripts should include some automated tests (Issue #6)
I'm looking into it right now. It pulled from staging and it is passing all the tests locally. Is it the staging branch that is causing this problem, or is it a different branch?
— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/grainger-illinois/CTCast/issues/6*issuecomment-1295483296__;Iw!!DZ3fjg!9d_M72jDsE2PuGgGJxAIU9kKo2Gvcmvy2cz4LM4sV3pgJJ3vfNBIMeAxAwdEg2yhKUdhgGaoig-X5Mo9kE9IZnx93xo$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABCC52BTDZN3Y74JNOXSMDTWFRAMTANCNFSM6AAAAAAQAROLEY__;!!DZ3fjg!9d_M72jDsE2PuGgGJxAIU9kKo2Gvcmvy2cz4LM4sV3pgJJ3vfNBIMeAxAwdEg2yhKUdhgGaoig-X5Mo9kE9IPRyVDv8$. You are receiving this because you commented.Message ID: @.***>
@tps7 I believe we can close this issue now? Ideally, as part of closing it can you add a comment that point to the commit hash that it was fixed in.
Issue closed build scripts now include basic automated tests
The new playwright test in the github action build fails when running on macos- 2022-10-28T19:24:40.8256870Z 1) basic_tests.spec.ts:157:1 › Sends Text Correctly ============================================== 2022-10-28T19:24:40.8257530Z 2022-10-28T19:24:40.8258970Z �[31mTest timeout of 30000ms exceeded.�[39m 2022-10-28T19:24:40.8260080Z 2022-10-28T19:24:40.8260980Z locator.click: Timeout 30000ms exceeded. 2022-10-28T19:24:40.8262540Z =========================== logs =========================== 2022-10-28T19:24:40.8263550Z waiting for selector "button:has-text("Submit")" 2022-10-28T19:24:40.8265030Z selector resolved to visible <button tabindex="0" type="submit" id="zoompost" class="…>… 2022-10-28T19:24:40.8266250Z attempting click action 2022-10-28T19:24:40.8267520Z waiting for element to be visible, enabled and stable 2022-10-28T19:24:40.8268670Z element is visible, enabled and stable 2022-10-28T19:24:40.8269480Z scrolling into view if needed 2022-10-28T19:24:40.8270650Z done scrolling 2022-10-28T19:24:40.8271410Z performing click action 2022-10-28T19:24:40.8273480Z ============================================================ 2022-10-28T19:24:40.8314630Z 2022-10-28T19:24:40.8314830Z 176 | expect(s2).toBe("hello") 2022-10-28T19:24:40.8315690Z 177 | const r = window.locator('button:has-text("Submit")') 2022-10-28T19:24:40.8316460Z > 178 | await r.click() 2022-10-28T19:24:40.8318130Z | ^ 2022-10-28T19:24:40.8318910Z 179 | //await (window.waitForTimeout(2000)) 2022-10-28T19:24:40.8319780Z 180 | //console.log('done') 2022-10-28T19:24:40.8320560Z 181 |