graingert / slimerjs

NPM wrapper for installing phantomjs
Other
29 stars 9 forks source link

Bump slimerjs version to 0.9.6 #19

Closed jnv closed 9 years ago

jnv commented 9 years ago

0.9.6 was released on June 8th.

graingert commented 9 years ago

Nice

jnv commented 9 years ago

Seems Node 0.8 will keep on erroring. However with updated dependencies it works nicely on Node 0.12 and io.js: https://github.com/jnv/slimerjs/tree/iojs (well, tests pass, anyway)

jnv commented 9 years ago

@graingert Could you please merge this patch? Or is there any issue with it?

graingert commented 9 years ago

I can't merge this on my phone because Travis is failing.

Can you create a PR fixing the Travis build by dropping 0.8 and adding 0.12/io.js?

jnv commented 9 years ago

Ah, I see, sure! I'll rebase this one once #20 is merged. Thanks!

jnv commented 9 years ago

Alright, it's good to go!