install.js - Support overriding the download url to install from a local repository

thhalm-talkwalker commented 9 years ago

We use Artifactory to cache our dependent artifacts. In order to seamlessly integrate Slimerjs in our build process we need to be able to override the prefix of the download URL like it is possible for the phantom js npm package:

function getDownloadUrl() {
  var cdnUrl = process.env.npm_config_phantomjs_cdnurl ||
      process.env.PHANTOMJS_CDNURL ||
      'https://bitbucket.org/ariya/phantomjs/downloads'
  var downloadUrl = cdnUrl + '/phantomjs-' + helper.version + '-'
  ...

https://github.com/Medium/phantomjs/blob/master/install.js

Thanks in advance.

graingert commented 9 years ago

If this feature is in upstream, I'd rather accept a pull request to merge upstream and make the Slimer customisations

thhalm-talkwalker commented 9 years ago

was duplicate of #16, fine for me to merge upstream

graingert / slimerjs

install.js - Support overriding the download url to install from a local repository #22